Use specific netlink families for android #75
Conversation
Android doesn't allow netlink_xfrm & netlink_nflog in his base policy in enforce mode. (see [here](https://android.googlesource.com/platform/system/sepolicy/+/3aa1c1725ea2b6fd452c5771629dcfc50a351538/public/app.te#396)) this cause a _permission denied_ when NewTransport method is called on android, however it's look like that only *netlink route* is needed, so we just have to limit netlink families support on android build to NETLINK_ROUTE only when netlink.NewHandle is called.
We definitely want to support Android, we just don't test on android... Please file patches and/or bugs like this whenever you find something that doesn't work on android.
This change looks correct. We're using netlink to find the correct socket when dialing some remote address. |
instead of android only.
|
Nice! however we still need a build constraint here since
I will! But don't worry too much, this is a rare case, other libp2p libs works pretty well on mobile (ios/android) |
|
Thanks! |
Hi there !
I work at Berty and actually use this lib along with libp2p on mobile.
Since a recent change and more particularly since the introduction of netlink for the reuse port, we can't use this lib anymore on Android.
Android doesn't allow netlink_xfrm & netlink_nflog in his base policy in enforce mode (see here).
this cause a permission denied when NewTransport method is called on android:
However it's look like that only netlink route is needed, so we tried to limit netlink
families support on android build to NETLINK_ROUTE only when netlink.NewHandle is called, it seems good enough in our case and don’t cause any error anymore! 😄
I know you have no need to support android, but this change should not impact you since it will only build on android. Also, to be honnest, i'm not sure I understand all the implication of this change, it’s maybe not the good way to go, I’d like your advice on the subject.